nsWifiMonitor.cpp: duplicate include "nsServiceManagerUtils.h"
Categories
(Core :: Networking, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: ktumuhairwe24, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=c++][necko-triaged])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
https://searchfox.org/mozilla-central/source/netwerk/wifi/nsWifiMonitor.cpp#21
duplicate include on "nsServiceManagerUtils.h"
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 1•2 years ago
|
||
Hello Sylvestre, I hope you are well.
I'm Komuhangi Tumuhairwe, an outreachy applicant interested in interning with firefox.
Can I please have more information on what is required to be done here.
|
Reporter | |
Comment 2•2 years ago
|
||
Hello
Removing the duplicate header in the code source
|
|
Assignee | |
Comment 3•2 years ago
|
||
Sylvestre, I have been going through the code file nsWifiMonitor.cpp and both "nsServiceManagerUtils.h" and "nsComponentManagerUtils.h" seem to have been included more than once. Is there a particular reason for this or are they both defects with their double inclusion.
|
|
Reporter | |
Comment 4•2 years ago
|
||
Remove one of these two:
https://searchfox.org/mozilla-central/source/netwerk/wifi/nsWifiMonitor.cpp#7,21
|
|
Assignee | |
Comment 5•2 years ago
|
||
Thank you for your guidance Sylvestre, as I commit using " hg commit -m "Bug 1234567 - [devtools] Implement feature XYZ. r=name,name2!"" what can be put in the [devtools] for this particular bug.
|
|
Assignee | |
Comment 6•2 years ago
|
||
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
Description
•